Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create scorecard.yml #676

Merged
merged 3 commits into from
Aug 7, 2024
Merged

chore: create scorecard.yml #676

merged 3 commits into from
Aug 7, 2024

Conversation

rvema
Copy link
Contributor

@rvema rvema commented Aug 6, 2024

Enabling OpenSSF Scorecard would help git-proxy project improve its security practices and help consumers evaluate the safety of their dependencies.

Fixes #675

Copy link

linux-foundation-easycla bot commented Aug 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rvema / name: Ragha Vema (6ec4e22, f24fa32)
  • ✅ login: JamieSlome / name: Jamie Slome (1f2d698)

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit f24fa32
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66b3a2d25fbbed000845d4a1

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (118678d) to head (f24fa32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome self-requested a review August 7, 2024 09:26
@JamieSlome JamieSlome changed the title Create scorecard.yml chore: create scorecard.yml Aug 7, 2024
@JamieSlome
Copy link
Member

@rvema - thank you for your PR 👍 ❤️ A great idea to get this added to the project.

Are you able to take a look at the FINOS EasyCLA? You'll need to sign this before your PR can be merged.

@JamieSlome
Copy link
Member

@rvema - shall we also include a badge in the README.md with the score?

@rvema
Copy link
Contributor Author

rvema commented Aug 7, 2024

Sure , let me add the badge and sign the cla

@rvema
Copy link
Contributor Author

rvema commented Aug 7, 2024

@JamieSlome added the badge but the score will not be there and will autofix once it runs at least 1 time on push. For now it will be run on every push to main branch and on a schedule

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 6072b57 into finos:main Aug 7, 2024
14 checks passed
@JamieSlome
Copy link
Member

Thank you for the contribution @rvema ❤️

Hopefully the first of many!

Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
chore: create scorecard.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable OpenSSF Scorecard
2 participants