Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of activeClassName in react-router-dom v6 ⬆️ #451

Closed
wants to merge 6 commits into from

Conversation

maoo
Copy link
Member

@maoo maoo commented Feb 26, 2024

No description provided.

@maoo maoo requested a review from JamieSlome February 26, 2024 19:41
@JamieSlome
Copy link
Member

@maoo - can you take care of the merge conflicts?

@maoo
Copy link
Member Author

maoo commented Feb 27, 2024

@maoo - can you take care of the merge conflicts?

done!

@JamieSlome
Copy link
Member

@maoo - I've introduced the changes directly to reconcile 👍 Thank you ❤️

We can now focus on the activeClassName issue here...

@JamieSlome JamieSlome changed the title fix: fix user.jsx ; various fixes on React code Replace usage of activeClassName in react-router-dom v6 ⬆️ Feb 28, 2024
@JamieSlome
Copy link
Member

As referenced in the commit message above, activeClassName is no longer required and the <Sidebar /> component is working as expected.

Closing 👍 🎉

@JamieSlome JamieSlome closed this Feb 29, 2024
@JamieSlome JamieSlome deleted the user-page-fixes branch February 29, 2024 14:47
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants