Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bundle CSL license file into FDC3 NPM module #1209

Open
kriswest opened this issue May 8, 2024 · 5 comments · May be fixed by #1309
Open

Don't bundle CSL license file into FDC3 NPM module #1209

kriswest opened this issue May 8, 2024 · 5 comments · May be fixed by #1309
Labels
bug Something isn't working project infrastructure
Milestone

Comments

@kriswest
Copy link
Contributor

kriswest commented May 8, 2024

The CSL license file is being bundled into the FDC3 NPM module. The CSL governs the Standard and its documentation, but any software or source code (i.e. what the NPM module contains) is distributed under Apache 2.0 instead.

While the package.json's license field indicates Apache-2.0, CI tools that inspect the module (such as JFrog Xray https://jfrog.com/help/r/jfrog-security-documentation/managing-compliance-licenses) will pick up the embedded license and may make it more difficult for firms to onboard the library, unnecessarily.

Update the build and re-release the module without bundling the CSL license files (License.md - License.spdx can remain as it indicates Apache-2.0).

@bingenito @robmoffat

@kriswest kriswest added bug Something isn't working project infrastructure labels May 8, 2024
@wang-wayne
Copy link

wang-wayne commented Jul 17, 2024

I will work on this issue.

@robmoffat
Copy link
Member

Hi @wang-wayne,

We'd love your help! There is a wider piece of work going on in the FDC3 world around https://github.com/finos-labs/fdc3-for-the-web, which we are going to merge back into the main FDC3 project.

As we do that, we're going to adopt a "monorepo" approach, which I feel this CSL issue is definitely related to.

If you are interested in helping out with that wider piece of work, drop me a mail at rob.moffat@finos.org because I think I'm going to need to set up a meeting on this to try and make sure we do it properly

thanks!

@wang-wayne
Copy link

I thought I just needed to exclude the license files when running webpack. I don't have experience with monorepo. I'm sorry I couldn't be more helpful.

@kriswest
Copy link
Contributor Author

As far as we can tell, you can't just exclude the LICENSE.md file, so its a case of restructuring the repo to separate the software distribution (which is under the Apache 2.0 license) from the the Standard's documentation (which is under the CSL).

@robmoffat
Copy link
Member

looping @Lecss

@kriswest kriswest added this to the 2.2 candidates milestone Sep 20, 2024
@kriswest kriswest linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants