Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme that warnings do not prevent submit #447

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Update readme that warnings do not prevent submit #447

merged 1 commit into from
Apr 9, 2019

Conversation

Noitidart
Copy link
Contributor

I think this is a correction. If it is not, please reject.

@codecov
Copy link

codecov bot commented Mar 24, 2019 •
edited
Loading

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #447   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         210    210           
  Branches       62     62           
=====================================
  Hits          210    210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ca5f1...60f5258. Read the comment docs.

@erikras
Copy link
Member

erikras commented Apr 9, 2019

The original way can be read correctly where "that prevents submission" modifies "error", but your wording is definitely more clear.

@erikras erikras merged commit 5f036e2 into final-form:master Apr 9, 2019
@Noitidart
Copy link
Contributor Author

The original way can be read correctly where "that prevents submission" modifies "error", but your wording is definitely more clear.

Oh gosh I see you're totally right. Thanks so much still for the complement on my wording and even merging it! :)

@lock
Copy link

lock bot commented May 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noitidart @erikras