Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReactFinalForm.js]: Add a test for 100% test coverage #307

Merged
merged 2 commits into from
Jul 23, 2018
Merged

[ReactFinalForm.js]: Add a test for 100% test coverage #307

merged 2 commits into from
Jul 23, 2018

Conversation

skvale
Copy link

@skvale skvale commented Jul 22, 2018

The test coverage was so close to 100%

[test] ---------------------|----------|----------|----------|----------|-------------------|
[test] File                 |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
[test] ---------------------|----------|----------|----------|----------|-------------------|
[test] All files            |      100 |    98.97 |      100 |      100 |                   |
[test]  Field.js            |      100 |      100 |      100 |      100 |                   |
[test]  FormSpy.js          |      100 |      100 |      100 |      100 |                   |
[test]  ReactFinalForm.js   |      100 |    95.65 |      100 |      100 |           106,109 |
[test]  diffSubscription.js |      100 |      100 |      100 |      100 |                   |
[test]  getValue.js         |      100 |      100 |      100 |      100 |                   |
[test]  isReactNative.js    |      100 |      100 |      100 |      100 |                   |
[test]  isSyntheticEvent.js |      100 |      100 |      100 |      100 |                   |
[test]  renderComponent.js  |      100 |      100 |      100 |      100 |                   |
[test]  shallowEqual.js     |      100 |      100 |      100 |      100 |                   |
[test] ---------------------|----------|----------|----------|----------|-------------------|

@codecov
Copy link

codecov bot commented Jul 22, 2018 •
edited
Loading

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #307   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         205    205           
  Branches       61     61           
=====================================
  Hits          205    205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec9c7e...71dd1df. Read the comment docs.

@erikras erikras merged commit 90459e7 into final-form:master Jul 23, 2018
@erikras
Copy link
Member

erikras commented Jul 23, 2018

Nice work! Thanks! ❤️

@lock
Copy link

lock bot commented Aug 22, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skvale @erikras