Issue #715 Update fs.lstat.spec.js to have proper const and let instead of var and added 'use strict' #727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 86.71% 86.63% -0.08%
==========================================
Files 16 16
Lines 1746 1736 -10
==========================================
- Hits 1514 1504 -10
Misses 232 232
Continue to review full report at Codecov.
|
|
Hi @hoaianhkhang, good work! I think you can make your pull request better by giving some desciption of the changes you have made. if you click on the 3 horizontal dots you will be given an option to edit your description and you can describe your changes. |
There was a problem hiding this comment.
This looks good.
You can actually change all the let fs = util.fs(); and let fsPromises = util.fs().promises; to use const vs. let, since the variable will never change after being declared. Please do those changes and let me know when it's updated, so I can re-review.
|
I have changed the file, can you check it again please? |
| @@ -13,7 +13,6 @@ describe('fs.lstat', function() { | |||
|
|
|||
| it('should return an error if path does not exist', function(done) { | |||
| const fs = util.fs(); | |||
|
|
|||
There was a problem hiding this comment.
Why remove all these blank lines? It's normally a bad idea to touch lines that aren't really part of this fix. The reason it's generally avoided is that it will alter the history of these lines in git, making them look like they were changed in this PR, but really they weren't.
There was a problem hiding this comment.
I have changed the file again with the space
I edit the code to change some let into const and tested it again