Issue 456 #504
Closed
Issue 456 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHKol
reviewed
Sep 24, 2018
tests/spec/fs.write.spec.js
Outdated
| @@ -5,6 +5,18 @@ var expect = require('chai').expect; | |||
| describe('fs.write', function() { | |||
| beforeEach(util.setup); | |||
| afterEach(util.cleanup); | |||
|
|
|||
| // the file is underfined, will create problem | |||
There was a problem hiding this comment.
Typo nit: 'underfined' might be intended to spell 'undefined'.
There was a problem hiding this comment.
Thank you for telling me, I will fix the problem late.
humphd
requested changes
Oct 9, 2018
|
|
||
| // if the file is undefined, it will create problems | ||
| // | ||
| it('should be a error',function(done){ |
There was a problem hiding this comment.
Please move your comment above into the test message like this:
it('should error if the file name is undefined', function(done) {
humphd
added a commit
that referenced
this pull request
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is the success, the filename is undefined, when we write a file from original to a destination.
I change code at fs.write.spec.js