-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with changes to node's Buffer #547
Comments
Great to see this being addressed. I am currently using Filer.Buffer in a isomorphic app and on Node I'm getting this issue. |
@ilDon, would you be willing to toss a snippet of code similar to what you're doing in your APP, and then I can add a regression test for the case you need to make sure we support. Thanks. |
I'm using
Thanks! |
OK, this is done. We'll do what node does and support both ways (ctor + |
In node,
new Buffer(8)
gives[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
We should prepare for this, and alter how we expect to use Buffers in Filer.The text was updated successfully, but these errors were encountered: