Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint): allow specifying eslint config file #71

Merged
merged 3 commits into from
Oct 7, 2021
Merged

feat(eslint): allow specifying eslint config file #71

merged 3 commits into from
Oct 7, 2021

Conversation

elwynelwyn
Copy link
Contributor

Add configuration option to pass through to ESLint that will specify a custom path for ESLint to find the configuration file to be used.

This is useful in our situation (legacy project with multiple builds + eslints in the mix) when the root eslintrc file is incorrect for the code that Vite is building. New code is separated in a pseudo monorepo structure so we need to be able to point at a different base eslintrc config file.

@elwynelwyn
feat: allow specifying eslint config file
19adb83 
Add configuration option to pass through to ESLint that will specify a custom
path for ESLint to find the configuration file to be used.
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #71 (2fb8a8e) into main (df4917e) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   34.52%   34.11%   -0.41%     
==========================================
  Files          13       13              
  Lines         588      595       +7     
  Branches      114      118       +4     
==========================================
  Hits          203      203              
- Misses        384      391       +7     
  Partials        1        1
Impacted Files Coverage Δ
...es/vite-plugin-checker/src/checkers/eslint/main.ts 0.00% <0.00%> (ø)
packages/vite-plugin-checker/src/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4917e...2fb8a8e. Read the comment docs.

@fi3ework
Copy link
Owner

Thanks for your PR! I'll take a closer look over the weekend ASAP.

@elwynelwyn
Copy link
Contributor Author

Sorry to bug ya, don't suppose you've got a moment to check this?

@fi3ework
Copy link
Owner

fi3ework commented Sep 17, 2021 •
edited
Loading

@elwynelwyn Sorry, I'm too busy to do OSS work recently. I might review this at 10.1 ~ 10.7 or got a time before it. I'm still trying my best to maintain this project. 🥺

@fi3ework fi3ework merged commit 60ab2d0 into fi3ework:main Oct 7, 2021
@fi3ework
Copy link
Owner

fi3ework commented Oct 7, 2021

@elwynelwyn Thanks for PR! Sorry to be so late in responding. I'll add some test cases and release a new version. Thanks!

@dharmaturtle
Copy link

May I ask for a release in the near future? I'd like to use this new feature - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elwynelwyn @codecov-commenter @fi3ework @dharmaturtle