Add maxWarnings option to eslint
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikew
commented
Aug 21, 2021
| return ['eslint', ['--ext', ext.join(','), ...files]] | ||
| maxWarnings ??= -1 | ||
|
|
||
| return ['eslint', ['--ext', ext.join(','), `--max-warnings=${maxWarnings}`, ...files]] |
There was a problem hiding this comment.
Have to use = here, as eslint --max-warnings -1 fails because it tries to parse -1 as a flag.
|
Thanks for your PR! I'll take a closer look over the weekend ASAP. |
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 34.52% 34.40% -0.12%
==========================================
Files 13 13
Lines 588 590 +2
Branches 114 115 +1
==========================================
Hits 203 203
- Misses 384 386 +2
Partials 1 1
Continue to review full report at Codecov.
|
fi3ework
force-pushed
the
eslint-max-warnings
branch
from
14bebd1 to
c09ece4
Compare
|
@mikew Thanks for your PR! Sorry to be so late in responding. I'll add some test cases and refactor some code then release a new version. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68