Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning level logging #51

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Fix warning level logging #51

merged 2 commits into from
Jul 22, 2021

Conversation

fgblomqvist
Copy link
Contributor

Fixes #50.

@codecov-commenter
Copy link

Codecov Report

Merging #51 (9455f3d) into main (1403f6f) will increase coverage by 1.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   30.03%   31.59%   +1.56%     
==========================================
  Files          13       13              
  Lines         576      576              
  Branches      118      118              
==========================================
+ Hits          173      182       +9     
+ Misses        403      394       -9     
Impacted Files Coverage Δ
packages/vite-plugin-checker/src/logger.ts 28.31% <100.00%> (+7.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1403f6f...9455f3d. Read the comment docs.

@fi3ework fi3ework merged commit 5b0ac3a into fi3ework:main Jul 22, 2021
@fi3ework
Copy link
Owner

fi3ework commented Jul 22, 2021

Thank you very much! @fgblomqvist 👍 I added some unit test based on your commit.

@fgblomqvist fgblomqvist deleted the fix-warning-level branch July 22, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning level gets logged as Error
3 participants