Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for all checkers to finish during build #37

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

zsparal
Copy link
Contributor

@zsparal zsparal commented Jul 18, 2021

closes #38

@codecov-commenter
Copy link

Codecov Report

Merging #37 (05dde9f) into main (e1a0089) will increase coverage by 0.03%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   29.87%   29.91%   +0.03%     
==========================================
  Files          13       13              
  Lines         559      565       +6     
  Branches      114      115       +1     
==========================================
+ Hits          167      169       +2     
- Misses        392      396       +4     
Impacted Files Coverage Δ
packages/vite-plugin-checker/src/main.ts 65.45% <53.84%> (-3.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a0089...05dde9f. Read the comment docs.

@fi3ework
Copy link
Owner

@Gustorn Good catch! Thank you! 🤩

@fi3ework fi3ework merged commit 257358f into fi3ework:main Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The checker does not wait for all child processes to finish in build mode
3 participants