-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-tsc): support volar v1.0.14 #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vite-plugin-checker failed.
|
cexbrayat
force-pushed
the
fix/193-vue-tsc-v1.0.14
branch
2 times, most recently
from
December 18, 2022 15:33
345b6ee
to
35084f5
Compare
Same problem here. |
johnsoncodehk
added a commit
to vuejs/language-tools
that referenced
this pull request
Dec 20, 2022
I will shim vue-tsc/out/proxy.js for v1.0.x, and planed to remove the shim in v1.1 and later. |
fi3ework
reviewed
Dec 20, 2022
packages/vite-plugin-checker/src/checkers/vueTsc/prepareVueTsc.ts
Outdated
Show resolved
Hide resolved
cexbrayat
force-pushed
the
fix/193-vue-tsc-v1.0.14
branch
from
December 20, 2022 16:33
35084f5
to
9c987d1
Compare
fi3ework
reviewed
Dec 21, 2022
packages/vite-plugin-checker/src/checkers/vueTsc/prepareVueTsc.ts
Outdated
Show resolved
Hide resolved
Fixes fi3ework#193 volar v1.0.14 renamed the `proxy.ts` file in `index.ts` and changed `createProgramProxy` into `createProgram`.
cexbrayat
force-pushed
the
fix/193-vue-tsc-v1.0.14
branch
from
December 21, 2022 07:09
9c987d1
to
601bcff
Compare
fi3ework
approved these changes
Dec 21, 2022
Thanks! |
johnsoncodehk
added a commit
to vuejs/language-tools
that referenced
this pull request
Feb 11, 2023
@fi3ework - I'm seeing this issue again on latest versions of things... maybe @johnsoncodehk deleting the extra proxy file changed something? |
Tracks in #193. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
volar v1.0.14 renamed the
proxy.ts
file inindex.ts
and changedcreateProgramProxy
intocreateProgram
.