Skip running ESLint on ignored files #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-checker canceled.
|
|
@kylewlacy will it fix this issue? |
|
@Scanerrr Yes, it should fix that warning! |
|
I'd love to see this get merged, nicely done @kylewlacy ! This is causing a lot of noise on my project. |
fi3ework
reviewed
Sep 3, 2022
fi3ework
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started configuring
vite-plugin-checkerfor one of my projects today, and I ran into the same issue described in #115. I'm not entirely clear why that issue was closed, as it seemed to me thatvite-plugin-checkerwas still trying to lint ignored files, even in the latest release.This PR updates the ESLint checker to resolve #115 more directly. Now, when a file changes, the plugin calls
eslint.isPathIgnoredto see if the file has been ignored in the ESLint config. This should avoid the warning.