fix: use abs file path as error ID

fi3ework · Jun 10, 2021 · fdc0360 · fdc0360
1 parent cf16f1b
commit fdc0360
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/examples/vue2-ts/src/components/HelloWorld.vue b/examples/vue2-ts/src/components/HelloWorld.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="hello">
-    <h1>{{ msg12 }}</h1>
+    <h1>{{ msg123 }}</h1>
     <p>
       For a guide and recipes on how to configure / customize this project,<br />
       check out the

diff --git a/src/utils.ts b/src/utils.ts
@@ -88,17 +88,18 @@ export function lspDiagnosticToViteError(
   if (!diagnostics.diagnostics.length) return null
 
   const d = diagnostics.diagnostics[0]
+  const absPath = uriToAbsPath(diagnostics.uri)
   const range = d.range
   let loc: ErrorPayload['err']['loc']
   if (range) {
     loc = {
-      file: uriToAbsPath(diagnostics.uri),
+      file: absPath,
       line: range.start.line + 1,
       column: range.start.character + 1,
     }
   }
 
-  const fileText = readFileSync(uriToAbsPath(diagnostics.uri), 'utf-8')
+  const fileText = readFileSync(absPath, 'utf-8')
   const location = range2Location(d.range)
   const columns = codeFrameColumns(fileText, location)
 
@@ -112,7 +113,7 @@ export function lspDiagnosticToViteError(
           columns
       ),
       stack: '',
-      id: d.source,
+      id: absPath,
       plugin: 'vite-plugin-ts-checker',
       loc,
     }
@@ -122,7 +123,7 @@ export function lspDiagnosticToViteError(
   return {
     message: ts.flattenDiagnosticMessageText(d.message, formatHost.getNewLine()),
     stack: '',
-    id: 'dummy source',
+    id: absPath,
     plugin: 'vite-plugin-ts-checker',
     loc,
   }