fix: clean previous console

fi3ework · Jun 14, 2021 · fa47e77 · fa47e77
1 parent 5322714
commit fa47e77
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 21 deletions.
diff --git a/examples/react-ts/src/NotUsed.tsx b/examples/react-ts/src/NotUsed.tsx
@@ -0,0 +1,6 @@
+import React, { useState } from 'react'
+
+export const NotUsedComponentButForTestConsoleClear = () => {
+  const [] = useState<string>()
+  return <div>233</div>
+}
diff --git a/packages/vite-plugin-checker/package.json b/packages/vite-plugin-checker/package.json
@@ -27,6 +27,7 @@
   "homepage": "https://github.com/fi3ework/vite-plugin-checker",
   "dependencies": {
     "@babel/code-frame": "^7.12.13",
+    "log-update": "^4.0.0",
     "npm-run-path": "^4.0.1",
     "strip-ansi": "^6.0.0",
     "tiny-invariant": "^1.1.0",

diff --git a/packages/vite-plugin-checker/src/checkers/tsc.ts b/packages/vite-plugin-checker/src/checkers/tsc.ts
@@ -3,6 +3,7 @@ import invariant from 'tiny-invariant'
 import ts from 'typescript'
 import { ErrorPayload } from 'vite'
 import { isMainThread, parentPort } from 'worker_threads'
+import logUpdate from 'log-update'
 
 import { ensureCall, formatHost, tsDiagnosticToViteError } from '../utils'
 import { createScript } from '../worker'
@@ -45,26 +46,33 @@ const createDiagnostic: CreateDiagnostic<Pick<PluginConfig, 'typescript'>> = (ch
         )
       }
 
+      let logChunk: { diagnostics: string | null; message: string | null } = {
+        diagnostics: null,
+        message: null,
+      }
+
       // https://github.com/microsoft/TypeScript/blob/a545ab1ac2cb24ff3b1aaf0bfbfb62c499742ac2/src/compiler/watch.ts#L12-L28
       const reportDiagnostic = (diagnostic: ts.Diagnostic) => {
-        const originalDiagnostic = ts.formatDiagnosticsWithColorAndContext([diagnostic], formatHost)
+        const formattedDiagnostics = ts.formatDiagnosticsWithColorAndContext(
+          [diagnostic],
+          formatHost
+        )
 
         if (!currErr) {
           currErr = tsDiagnosticToViteError(diagnostic)
         }
 
-        ensureCall(() => {
-          ts.sys.write(originalDiagnostic)
-        })
+        logChunk.diagnostics = formattedDiagnostics
       }
 
       const reportWatchStatusChanged: ts.WatchStatusReporter = (
-        diagnostic
-        // newLine,
-        // options,
-        // errorCount
+        diagnostic,
+        newLine,
+        options,
+        errorCount
         // eslint-disable-next-line max-params
       ) => {
+        // logChunk = []
         // https://github.com/microsoft/TypeScript/issues/32542
         switch (diagnostic.code) {
           case 6032: // Incremental build
@@ -83,11 +91,16 @@ const createDiagnostic: CreateDiagnostic<Pick<PluginConfig, 'typescript'>> = (ch
                 },
               })
             }
-
-            ensureCall(() => {
-              ts.sys.write(os.EOL + os.EOL + diagnostic.messageText.toString())
-            })
         }
+        ensureCall(() => {
+          const diagnosticMessage = os.EOL + os.EOL + diagnostic.messageText.toString()
+          logChunk.message = diagnosticMessage
+          if (errorCount === 0) {
+            logChunk.diagnostics = null
+          }
+          const d = logChunk.diagnostics === null ? '' : logChunk.diagnostics + os.EOL
+          logUpdate(d + logChunk.message)
+        })
       }
 
       // https://github.com/microsoft/TypeScript/issues/32385

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml