fix: support Windows batch file

fi3ework · Jun 9, 2021 · f1c7d25 · f1c7d25
1 parent ed69546
commit f1c7d25
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 101 deletions.
diff --git a/examples/vue-ts/package.json b/examples/vue-ts/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "scripts": {
     "dev": "vite",
-    "build": "vue-tsc --noEmit && vite build",
+    "build": "vite build",
     "serve": "vite preview"
   },
   "dependencies": {

diff --git a/src/cliMode.ts b/src/cliMode.ts
diff --git a/src/main.ts b/src/main.ts
@@ -1,10 +1,10 @@
 import { spawn } from 'child_process'
 import npmRunPath from 'npm-run-path'
+import os from 'os'
 import { ConfigEnv, Plugin } from 'vite'
-import { PluginOptions } from './types'
 
 import { createDiagnosis } from './apiMode'
-import { tscProcess } from './cliMode'
+import { PluginOptions } from './types'
 
 export default function Plugin(userOptions?: Partial<PluginOptions>): Plugin {
   const checker = userOptions?.checker ?? 'tsc'
@@ -14,18 +14,12 @@ export default function Plugin(userOptions?: Partial<PluginOptions>): Plugin {
 
   return {
     name: 'ts-checker',
-    config: (config, { command, mode }) => {
+    config: (config, { command }) => {
       viteMode = command
-      if (mode === 'cli') {
-        tscProcess.config(config)
-      } else {
-        diagnose = createDiagnosis({
-          root: userOptions?.root,
-          tsconfigPath: userOptions?.tsconfigPath,
-        })
-
-        diagnose.config(config)
-      }
+      diagnose = createDiagnosis({
+        root: userOptions?.root,
+        tsconfigPath: userOptions?.tsconfigPath,
+      })
     },
     buildStart: (options) => {
       if (viteMode === 'build') {
@@ -39,6 +33,7 @@ export default function Plugin(userOptions?: Partial<PluginOptions>): Plugin {
           cwd: process.cwd(),
           stdio: 'inherit',
           env: localEnv,
+          shell: os.platform() === 'win32',
         })
 
         if (enableBuild) {

diff --git a/src/types.ts b/src/types.ts
@@ -15,20 +15,6 @@ export interface PluginOptions {
    * Same as [Vite config](https://vitejs.dev/config/#root)
    */
   overlay: boolean
-  /**
-   * [WIP]
-   * 'cli': use `tsc --noEmit` or `vue-tsc --noEmit`
-   *  - No overlay support
-   *  - Original console output
-   *
-   * 'api': use TypeScript programmatic API
-   *  - Support overlay
-   *  - Almost the same console output as original
-   *
-   * @defaultValue
-   * if 'vueTsc' is true, then force set to 'cli', otherwise default to 'api'
-   */
-  // mode: 'cli' | 'api'
   /**
    * Root path to find tsconfig file
    * @defaultValue