fix: early exit when enableBuild is true (#61)

* Fix early exit * Throw error instead of process.exit * Run async on build * Go back to process.exit * Add semi-colons
fi3ework · Jul 31, 2021 · cc0912f · cc0912f
1 parent ba929c5
commit cc0912f
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/packages/vite-plugin-checker/src/main.ts b/packages/vite-plugin-checker/src/main.ts
@@ -62,23 +62,23 @@ export default function Plugin(userConfig: UserPluginConfig): Plugin {
     buildStart: () => {
       // for build mode
       // run a bin command in a separated process
-      if (viteMode !== 'build') return
+      if (viteMode !== 'build') return;
 
       // do not do anything when disable build mode
-      if (!enableBuild) return
+      if (!enableBuild) return;
 
       const localEnv = npmRunPath.env({
         env: process.env,
         cwd: process.cwd(),
         execPath: process.execPath,
-      })
-
-      Promise.all(checkers.map((checker) => spawnChecker(checker, userConfig, localEnv))).then(
-        (exitCodes) => {
-          const exitCode = exitCodes.find((code) => code !== 0) || 0
-          process.exit(exitCode)
-        }
-      )
+      });
+
+      // spawn an async runner that we don't wait for in order to avoid blocking the build from continuing in parallel
+      (async () => {
+        const exitCodes = await Promise.all(checkers.map((checker) => spawnChecker(checker, userConfig, localEnv)));
+        const exitCode = exitCodes.find((code) => code !== 0) ?? 0;
+        if (exitCode !== 0) process.exit(exitCode);
+      })();
     },
     configureServer(server) {
       // for dev mode (2/2)