Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix #995

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Typo fix #995

merged 1 commit into from
Nov 13, 2022

Conversation

sarthakpati
Copy link
Contributor

@sarthakpati sarthakpati commented Nov 9, 2022 •
edited
Loading

Fixes #{issue_number}.

Description
A few sentences describing the changes proposed in this pull request.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #995 (97601d2) into main (532c2d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          92       92           
  Lines        5810     5810           
=======================================
  Hits         5009     5009           
  Misses        801      801

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati
Copy link
Contributor Author

This is just a typo fix in the changelog.

@fepegar fepegar merged commit cde25ec into fepegar:main Nov 13, 2022
@fepegar
Copy link
Owner

fepegar commented Nov 13, 2022

Thanks, @sarthakpati. We really should have a better changelog, it's an important TODO of this project.

@all-contributors please add @sarthakpati for doc

@allcontributors allcontributors bot mentioned this pull request Nov 13, 2022
Merged
@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @sarthakpati! 🎉

@sarthakpati sarthakpati deleted the patch-1 branch November 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakpati @fepegar