Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blur using only the first standard deviation #772

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fix Blur using only the first standard deviation #772

merged 2 commits into from
Dec 7, 2021

Conversation

fepegar
Copy link
Member

@fepegar fepegar commented Dec 5, 2021

Fixes #769.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #772 (804ed19) into main (4e4be01) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   93.88%   93.87%   -0.02%     
==========================================
  Files          72       72              
  Lines        4514     4668     +154     
==========================================
+ Hits         4238     4382     +144     
- Misses        276      286      +10
Impacted Files Coverage Δ
...o/transforms/augmentation/intensity/random_blur.py 100.00% <100.00%> (ø)
torchio/data/queue.py 82.25% <0.00%> (-0.77%) ⬇️
torchio/data/image.py 89.70% <0.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4be01...804ed19. Read the comment docs.

@fepegar fepegar merged commit 68755fb into main Dec 7, 2021
@fepegar fepegar deleted the 769-fix-blur branch December 7, 2021 23:45
@fepegar
Copy link
Member Author

fepegar commented Dec 7, 2021

Thanks again for reporting, @rousseau.

@all-contributors please add @rousseau for bug

@allcontributors allcontributors bot mentioned this pull request Dec 7, 2021
Merged
@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @rousseau! 🎉

@fepegar fepegar restored the 769-fix-blur branch July 4, 2022 22:00
@fepegar fepegar deleted the 769-fix-blur branch July 4, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specific Blur for Multiple Images
1 participant
@fepegar