Remove channels_last kwarg from Image #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #684. SimpleITK is not very good for fMRI and dMRI images. After this commit, if 4 spatial dimensions are detected, we assume that the read image is of this nature and we move convert the temporal dimension into the channels dimension. The `channels_last` kwarg should no longer be necessary. It is important to take into account that images saved by TorchIO always put the channels in the 5th NIfTI dimension, not the 4th.
|
@all-contributors please add @efirdc for bug |
|
I've put up a pull request to add @efirdc! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #684.
SimpleITK is not very good for fMRI and dMRI images.
After this commit, if 4 spatial dimensions are detected, we assume that
the read image is of this nature and we move convert the temporal
dimension into the channels dimension.
The
channels_lastkwarg should no longer be necessary.It is important to take into account that images saved by TorchIO
always put the channels in the 5th NIfTI dimension, not the 4th.
Checklist
CONTRIBUTINGdocs and have a developer setup (especially important arepre-commitandpytest)pytestmake htmlinside thedocs/folder