Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum version for NumPy requirement #532

Merged
merged 2 commits into from
May 12, 2021
Merged

Set minimum version for NumPy requirement #532

merged 2 commits into from
May 12, 2021

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented May 12, 2021

Fixes #529.

Description
Setting the NumPy requirement to numpy>=1.15.0 so an iterable for axes can be passed to np.flip.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@fepegar fepegar changed the title 529 set minimum numpy Set minimum version for NumPy requirement May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021 •
edited
Loading

Codecov Report

Merging #532 (5c53b2c) into master (c7af603) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         124      124           
  Lines        6521     6521           
=======================================
  Hits         5976     5976           
  Misses        545      545
Impacted Files Coverage Δ
...hio/transforms/augmentation/spatial/random_flip.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7af603...5c53b2c. Read the comment docs.

@fepegar fepegar merged commit 4b766ea into master May 12, 2021
@fepegar fepegar deleted the 529-set-minimum-numpy branch May 12, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encounter "TypeError: only integer scalar arrays can be converted to a scalar index" when using random flip
1 participant
@fepegar