[SQL] Remove dependency on json crate #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
force-pushed
the
no-json-crate
branch
from
a1ea9b7
to
4b7d6ca
Compare
ryzhyk
requested changes
Sep 23, 2024
| @@ -157,6 +156,7 @@ public void postorder(DBSPTypeSemigroup type) { | |||
| aggregates::*, | |||
| variant::*, | |||
| }; | |||
| #[cfg(test)] | |||
There was a problem hiding this comment.
I see lines like this in the generated code:
sltsqlvalue::to_sql_row_impl! {
Tup16<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15>,
Tup18<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17>,
Tup11<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10>,
Tup12<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11>,
Tup13<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12>,
Tup14<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13>,
Tup15<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14>,
}These are not gated by cfg(test)
There was a problem hiding this comment.
these should be gone now
mihaibudiu
force-pushed
the
no-json-crate
branch
from
4500a56
to
7293372
Compare
mihaibudiu
force-pushed
the
no-json-crate
branch
from
7293372
to
32d659a
Compare
ryzhyk
approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
This is a postfix for PR 2557, bumping the version of a transitive dependency on google-cloud-gax. Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
ryzhyk
force-pushed
the
no-json-crate
branch
from
f279f24
to
13099ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.