dbsp: Summarize operator metadata into root in circuit profiles. #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, the root node in circuit profiles includes additional information that summarizes all the operators in the circuit, like this: ``` total size: 14385360 allocated bytes: 4.75 GiB used bytes: 4.75 GiB allocations: 34030654 shared bytes: 4.75 GiB batches: 210 storage size: 3.53 GiB merging batches: 20 merging size: 2.18 GiB merge reduction: 23.93% output redundancy: 0.00% ``` Signed-off-by: Ben Pfaff <blp@feldera.com>
ryzhyk
approved these changes
Sep 22, 2024
| @@ -174,6 +174,14 @@ impl WorkerProfile { | |||
| pub fn total_shared_bytes(&self) -> Result<HumanBytes, MetaItem> { | |||
| self.attribute_total_as_bytes(SHARED_BYTES_LABEL) | |||
| } | |||
|
|
|||
| pub fn merge(&mut self, other: &Self) { | |||
| for (id, dst) in self.metadata.iter_mut() { | |||
There was a problem hiding this comment.
It probably doesn't happen now, but if other has a different set of metrics, some of them can get lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the root node in circuit profiles includes additional information that summarizes all the operators in the circuit, like this: