[SQL] NULL values for columns with LATENESS are never considered late #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
force-pushed
the
issue2517
branch
from
fb480bd
to
0937eca
Compare
ryzhyk
requested changes
Sep 18, 2024
|
What do you suggest? |
|
Either the type is not null, and then it's clear what to do. If the type is nullable it means that null timestamps are expected. And then it means they have to be processed. Whether they are kept forever depends on what else the program does to them. |
|
@ryzhyk I don't think we can do any better than this, can you please approve this so we can merge it? |
ryzhyk
approved these changes
Sep 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
issue2517
branch
from
c70f9de
to
e0ff266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2517