[Datagen] time, date, timestamp range support with strings. #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2318. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz
changed the title
mihaibudiu
changed the title
mihaibudiu
approved these changes
Aug 28, 2024
| Ok(Some((a, b))) | ||
| } | ||
| Some((Value::String(a), Value::String(b))) => { | ||
| let unix_date: NaiveDate = NaiveDate::from_ymd_opt(1970, 1, 1).unwrap(); |
There was a problem hiding this comment.
If it's malformed will you get a decent message?
There was a problem hiding this comment.
line 74 and 76 will do the error handlign for malformed user strings
There was a problem hiding this comment.
what is the user experience?
There was a problem hiding this comment.
they'll get an error from the adapter -- currently they'll have to inspect the manager log but once we land error handling in manager this will be there too
| @@ -650,7 +770,8 @@ impl RecordGenerator { | |||
| if let Value::String(str) = obj { | |||
| str.clear(); | |||
|
|
|||
| let (min, max) = settings.range.unwrap_or((0, MAX_DATE_VALUE)); | |||
| let range = parse_range_for_date(field.name.as_str(), &settings.range)?; | |||
| let (min, max) = range.unwrap_or((0, MAX_DATE_VALUE)); | |||
There was a problem hiding this comment.
is 0 1970?
What if the range starts earlier?
There was a problem hiding this comment.
this is the default range if the user doesn't provide one
There was a problem hiding this comment.
but will it work with negative values?
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2318.
Is this a user-visible change (yes/no): ___