-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] Implement the NOW table as a generator #2301
Conversation
table, which should be larger than the previous value. | ||
| Operation | Description | Example | | ||
|---------------|---------------------|--------------------------------| | ||
| `NOW` | Returns a timestamp | `NOW()` => 2024-07-10 00:00:00 | | ||
|
||
:::warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need something to close the warning. Right now, all content after it shows up as a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I did. IT's just :::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, if you no longer see it when viewing with yarn start
then it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may have gotten lost in the edits when I moved this text to a different file.
I will add it back before I merge.
docs/sql/datetime.md
Outdated
table, which should be larger than the previous value. | ||
| Operation | Description | Example | | ||
|---------------|---------------------|--------------------------------| | ||
| `NOW` | Returns a timestamp | `NOW()` => 2024-07-10 00:00:00 | | ||
|
||
:::warning | ||
|
||
Programs that use `NOW()` can be very inefficient. For example, a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there programs using now() that will be efficient though? E.g., if it's just a projection that adds a column in a view which is then used for an ASOF join or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what I am fixing now
0978df5
to
2f8536f
Compare
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Fixes #2235