Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Implement the NOW table as a generator #2301

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[SQL] Implement the NOW table as a generator #2301

merged 2 commits into from
Aug 23, 2024

Conversation

mihaibudiu
Copy link
Collaborator

Fixes #2235

@mihaibudiu mihaibudiu requested a review from ryzhyk August 21, 2024 23:33
table, which should be larger than the previous value.
| Operation | Description | Example |
|---------------|---------------------|--------------------------------|
| `NOW` | Returns a timestamp | `NOW()` => 2024-07-10 00:00:00 |

:::warning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need something to close the warning. Right now, all content after it shows up as a warning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I did. IT's just :::

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if you no longer see it when viewing with yarn start then it's fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may have gotten lost in the edits when I moved this text to a different file.
I will add it back before I merge.

table, which should be larger than the previous value.
| Operation | Description | Example |
|---------------|---------------------|--------------------------------|
| `NOW` | Returns a timestamp | `NOW()` => 2024-07-10 00:00:00 |

:::warning

Programs that use `NOW()` can be very inefficient. For example, a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there programs using now() that will be efficient though? E.g., if it's just a projection that adds a column in a view which is then used for an ASOF join or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I am fixing now

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu mihaibudiu merged commit f44f93b into main Aug 23, 2024
4 of 5 checks passed
@mihaibudiu mihaibudiu deleted the now branch August 23, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] [adapter] Create an adapter to populate the NOW table
2 participants