Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark #2206

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Benchmark #2206

merged 5 commits into from
Aug 7, 2024

Conversation

blp
Copy link
Member

@blp blp commented Aug 7, 2024

We'd like to be able to graph speed, memory, and CPU consumption for Flink and Feldera. This series makes that possible.

Is this a user-visible change (yes/no): no

blp added 4 commits August 6, 2024 11:45
This performed best and it was what I manually configured each time anyway.

Signed-off-by: Ben Pfaff <blp@feldera.com>
The new API doesn't allow a pipeline to change if it is running or paused.

Signed-off-by: Ben Pfaff <blp@feldera.com>
This saves time counting 100M events if you are running this script a lot.

Signed-off-by: Ben Pfaff <blp@feldera.com>
Because this adds memory to every `run-nexmark.sh` result, it removes the
special case from the CI benchmarks in the `Earthfile`.

Signed-off-by: Ben Pfaff <blp@feldera.com>
@blp blp added the performance label Aug 7, 2024
@blp blp requested a review from aehmttw August 7, 2024 00:25
@blp blp self-assigned this Aug 7, 2024
@aehmttw
Copy link
Contributor

aehmttw commented Aug 7, 2024

I triggered a run of this for Flink so we can see if everything works in CI: https://github.com/feldera/feldera/actions/runs/10276370997

@blp
Copy link
Member Author

blp commented Aug 7, 2024 via email

@aehmttw
Copy link
Contributor

aehmttw commented Aug 7, 2024

I'm not sure if this is an issue with something being out of date on my machine, but I get this error when I try to run "run.py" as directed by the readme for benchmarking feldera-sql:

Stopping pipeline(s)...
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 700, in urlopen
    httplib_response = self._make_request(
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 446, in _make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 441, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.10/http/client.py", line 1375, in getresponse
    response.begin()
  File "/usr/lib/python3.10/http/client.py", line 318, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.10/http/client.py", line 287, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

@blp
Copy link
Member Author

blp commented Aug 7, 2024 via email

@blp
Copy link
Member Author

blp commented Aug 7, 2024

I'm not sure if this is an issue with something being out of date on my machine, but I get this error when I try to run "run.py" as directed by the readme for benchmarking feldera-sql:

Stopping pipeline(s)...
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 700, in urlopen
    httplib_response = self._make_request(
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 446, in _make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 441, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/lib/python3.10/http/client.py", line 1375, in getresponse
    response.begin()
  File "/usr/lib/python3.10/http/client.py", line 318, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.10/http/client.py", line 287, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

I get an error like that if I don't have the pipeline manager running.

This should reduce the log size substantially.

Signed-off-by: Ben Pfaff <blp@feldera.com>
@blp blp merged commit cad6d7e into main Aug 7, 2024
5 checks passed
@blp blp deleted the benchmark branch August 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants