Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor profiling-related improvements #1971

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Minor profiling-related improvements #1971

merged 3 commits into from
Jul 1, 2024

Conversation

ryzhyk
Copy link
Contributor

@ryzhyk ryzhyk commented Jun 29, 2024

Is this a user-visible change (yes/no): no

@ryzhyk ryzhyk requested a review from aehmttw June 29, 2024 20:06
Copy link
Contributor

@aehmttw aehmttw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nothing broke for me when running run.py, so it looks good to me.

Leonid Ryzhyk added 3 commits July 1, 2024 11:57
Improves readability of dataflow graphs.

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
Include the `shard` operator in the region.

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
Pass config flag to the pipeline to enable CPU profiler.  With this, the
`/dump_profile` endpoint will generate profiles including CPU usage
information.  I don't think this introduces any measurable overhead, to
the extent that we should probably make this the default.

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
@ryzhyk ryzhyk merged commit 47cb553 into main Jul 1, 2024
5 checks passed
@ryzhyk ryzhyk deleted the q0_prof branch July 1, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants