Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI regressions #1940

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Fix UI regressions #1940

merged 6 commits into from
Jun 25, 2024

Conversation

Karakatiza666
Copy link
Contributor

@Karakatiza666 Karakatiza666 commented Jun 25, 2024

Is this a user-visible change (yes/no): no (intra-sprint regressions and improvements)

Fix #1931 : Output buffer attributes required even when the output buffer is disabled
Fix #1932 : Output buffer size gets serialized as string instead of int
Fix #1933 : Kafka input connector creation dialog: CREATE button doesn't work
Fix #1936 : UI truncates fields even if there is room to display them entirely
Fix #1938 : "Application error" during pipeline creation
Add output buffer config validation to Snowflake Output
Add an error popup when validation error during connector creation cannot be handled

Signed-off-by: George <bulakh.96@gmail.com>
Add error message popup when connector creation error us not handled

Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
@Karakatiza666 Karakatiza666 added bug Something isn't working Web Console Related to the browser based UI javascript Pull requests that update Javascript code labels Jun 25, 2024
@Karakatiza666 Karakatiza666 requested a review from gz June 25, 2024 09:19
Signed-off-by: George <bulakh.96@gmail.com>
@gz
Copy link
Collaborator

gz commented Jun 25, 2024

If I don't set the output buffer, it just puts u64::max? I don't think it should insert anything if not specified?

image

@gz
Copy link
Collaborator

gz commented Jun 25, 2024

these should be integers?

Screenshot 2024-06-25 at 12 59 41 PM

Copy link
Collaborator

@gz gz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can merge this once the other two issues I mentioned in the comments are fixed

Signed-off-by: George <bulakh.96@gmail.com>
@Karakatiza666
Copy link
Contributor Author

If I don't set the output buffer, it just puts u64::max?

This is done by the backend

@Karakatiza666 Karakatiza666 merged commit c513448 into main Jun 25, 2024
5 checks passed
@Karakatiza666 Karakatiza666 deleted the fix-ui branch June 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code Web Console Related to the browser based UI
Projects
None yet
2 participants