I think most of these TODOs should be addressed in separate PRs.

For lifetimes, feel free to add 98eae77 to the PR

On wasm side, I suggest making rocksdb optional dependency, and enabling it in minimint, ln-gateway and mint-client-cli

Okay the build should be fixed although with the inclusion of C code GitHub wont be able to compile and test without clang tools (I'm not sure how that works). As for the TODO's I think I'll limit this PR to adding the remaining tests for the existing database trait and making rocksdb an optional dependency and enabling it in those files Maan2003 mentioned. The other changes such as the migration to transactions and the other TODO's will have separate PR's.

notes for CI:

• run cargo fmt
• install clang in nix
• make rocksdb optional dependency, so it is not used on wasm

feel free to include 9ebfa35 for wasm fixes

Thank you @maan2003! The current problem is getting this to compile in CI issues with what looks like a vendored librocksdb-sys which is incompatible with the nixos filesystem.

I added a commit to fix the builds in nix-shell. Just needs a fix for the flake based stuff now, I asked @wiredhikari and he had some ideas how to do it that need documentation, maybe you can coordinate with him.

You can try a nix flake update

Awesome that the tests finally run, you can probably clean up the git history a bit and squash some commits, then this should be ready for review!

What's the status here?

I have rebased and squashed some commits in https://github.com/Maan2003/minimint/commits/db-rebase

The rust-rocksdb PR was just approved, but not merged yet.

I think we should just rebase and merge this. Looks like ^^ will get in.