organize utlility functions in 'utils' (client-lib) #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaLS
force-pushed
the
client-lib-utils
branch
from
abfb96f to
f4db035
Compare
maan2003
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
I also wanted this for web client.
I made similar patch
Re-exporting bitcoin_hashes::hex::ToHex will help avoid direct dependency on bitcoin_hashes
elsirion
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
A few ideas on how this could develop going forward:
- remove
(de-)serialize_coinsor make it hex based since few to no people will directly use coins once bidirectional LN works - write our own hex impl? It's not that hard and one less dependency, otoh we could use crev to just review it (
hexin particular should be rather stable 😄).crevwill probably be the solution once we stabilize the project step by step.
But looks good and is useful now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fn moved are also useful for future modules (clientd for example) and should not only be in the mint-client bin