Make remove_entry async in IDatabaseTransaction trait #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sterc001guy
commented
Nov 22, 2022
m1sterc001guy
force-pushed
the
remove_async
branch
from
98db048 to
90ad6af
Compare
Codecov ReportBase: 66.96% // Head: 66.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 66.96% 66.89% -0.08%
==========================================
Files 113 113
Lines 16705 16713 +8
==========================================
- Hits 11187 11180 -7
- Misses 5518 5533 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
elsirion
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of making the IDatabaseTransaction async, this PR makes remove_entry and rollback_to_savepoint async. This allows the executor to switch to a different thread in case some I/O is happening during remove_entry or rollback_to_savepoint.
I am only changing remove_entry and rollback_to_savepoint currently to keep the PR smaller and easier to review. The rest of the functions will be made async next.