Modularization III-ish #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 64.26% // Head: 65.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 64.26% 65.05% +0.78%
==========================================
Files 112 111 -1
Lines 16412 16196 -216
==========================================
- Hits 10547 10536 -11
+ Misses 5865 5660 -205
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
elsirion
force-pushed
the
2022-11-modularization
branch
from
cc09e2a to
8977758
Compare
dpc
reviewed
Nov 19, 2022
| .register_async_method(path, move |params, state| { | ||
| Box::pin(async move { | ||
| let params = params.one::<serde_json::Value>()?; | ||
| // Using AssertUnwindSafe here is far from ideal. In theory this means we could |
There was a problem hiding this comment.
BTW. the whole UnwindSafe is one of a few broken things in Rust and possibly will be deprecated altogether. rust-lang/rust#40628
There was a problem hiding this comment.
I think it's a separate issue (created #943), I just copied the old code to adapt it.
dpc
reviewed
Nov 19, 2022
modules/fedimint-ln/src/lib.rs
Outdated
| type VerificationCache = LightningVerificationCache; | ||
|
|
||
| fn module_key(&self) -> fedimint_api::encoding::ModuleKey { | ||
| todo!() |
dpc
previously approved these changes
Nov 19, 2022
This automatically bridges the old modules into the new, type-erased module system
elsirion
force-pushed
the
2022-11-modularization
branch
from
8977758 to
6b6116d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at finishing modularization in a way that is quick, will allow external modules soon, but leaves most of the code moving of existing modules for later.