Move database impls into their own crates #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.43% // Head: 72.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 72.43% 72.38% -0.06%
==========================================
Files 85 85
Lines 11550 11590 +40
==========================================
+ Hits 8366 8389 +23
- Misses 3184 3201 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dpc
reviewed
Sep 22, 2022
fedimint-rocksdb/src/lib.rs
Outdated
| Ok(RocksDb(db)) | ||
| } | ||
|
|
||
| pub fn into_any(self) -> Box<dyn Database> { |
There was a problem hiding this comment.
This (_any) is a bit of a misnomer, as Any and dyn Trait are a different trait. into_dyn or into_boxed maybe?
There was a problem hiding this comment.
There's also a lot of to_any in the network stack. I should rename that too.
elsirion
force-pushed
the
2022-09-extract-db-impls
branch
from
047a3b0 to
6f54df1
Compare
elsirion
added a commit
to elsirion/fedimint
that referenced
this pull request
Sep 23, 2022
@dpc noted that `(in)to_any` is inaccurate in fedimint#611. fedimint#611 (comment)
elsirion
force-pushed
the
2022-09-extract-db-impls
branch
2 times, most recently
from
c39050b to
8810ff9
Compare
elsirion
force-pushed
the
2022-09-extract-db-impls
branch
from
8810ff9 to
59c72e3
Compare
dpc
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don't have to use feature flags on
fedimint-apianymore and make sure third party DB implementations would actually work.