CLI spend command makes exact change #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkitman
commented
Sep 19, 2022
| @@ -106,6 +106,11 @@ where | |||
| &self, | |||
| transaction: Transaction, | |||
| ) -> Result<(), TransactionSubmissionError> { | |||
| // we already processed the transaction before the request was received | |||
There was a problem hiding this comment.
Discovered this bug when an epoch is processed before the submit_transaction occurs.
jkitman
force-pushed
the
spend-command-makes-exact-change
branch
2 times, most recently
from
98a9d4d to
a8746cd
Compare
justinmoon
reviewed
Sep 20, 2022
|
Besides my 1 comment this looks good. And my comment is more of an optimization. |
jkitman
force-pushed
the
spend-command-makes-exact-change
branch
from
a8746cd to
f47d493
Compare
Codecov ReportBase: 72.38% // Head: 72.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 72.38% 72.43% +0.04%
==========================================
Files 85 85
Lines 11516 11543 +27
==========================================
+ Hits 8336 8361 +25
- Misses 3180 3182 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM. @elsirion would you take a look, too? |
justinmoon
approved these changes
Sep 20, 2022
elsirion
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
receive_coinsfunction is the way we should transfer ecash in production because it's the safer/faster option.However, for demonstrating ecash as a bearer note, this changes the
spend_ecashfunction so that it will reissue exact change for spending.Fixes #592