Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test RocksDB in the integration tests #582

Merged
merged 1 commit into from
Sep 16, 2022
Merged

test RocksDB in the integration tests #582

merged 1 commit into from
Sep 16, 2022

Conversation

jkitman
Copy link
Contributor

@jkitman jkitman commented Sep 16, 2022

Ensures we are testing our RocksDB code in the integration tests when mocks are disabled.

Will help test changes such as #581

@jkitman jkitman marked this pull request as ready for review September 16, 2022 16:56
@jkitman jkitman requested review from justinmoon and dpc September 16, 2022 16:58
NicolaLS
NicolaLS approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@NicolaLS NicolaLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but whats up with the "empty file" changes lib.sh and tmux-user-shell.sh ?

@jkitman
Copy link
Contributor Author

jkitman commented Sep 16, 2022

@dpc @NicolaLS making those shell scripts executable, not sure why they weren't already.

@justinmoon justinmoon merged commit a26e14b into fedimint:master Sep 16, 2022
@dpc
Copy link
Contributor

dpc commented Sep 16, 2022 •
edited
Loading

@dpc @NicolaLS making those shell scripts executable, not sure why they weren't already.

The problem (confusing thing) is that github UI is showing them as "empty".

Screenshot from 2022-09-16 12-23-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolaLS NicolaLS NicolaLS approved these changes

@justinmoon justinmoon justinmoon approved these changes

@m1sterc001guy m1sterc001guy m1sterc001guy approved these changes

@dpc dpc Awaiting requested review from dpc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkitman @dpc @m1sterc001guy @justinmoon @NicolaLS