Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-compile fedimint-sqlite in CI #1366

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Cross-compile fedimint-sqlite in CI #1366

merged 1 commit into from
Jan 17, 2023

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Jan 17, 2023

#1359 help

@dpc dpc force-pushed the justinmoon-cross-compile-sqlite-fix branch from c3f89c6 to 344580d Compare January 17, 2023 07:17
@dpc dpc changed the title Justinmoon cross compile sqlite fix Try fixes to help cross-compile fedimint-sqlite in CI Jan 17, 2023
@dpc dpc force-pushed the justinmoon-cross-compile-sqlite-fix branch from 344580d to a376555 Compare January 17, 2023 07:45
@dpc dpc force-pushed the justinmoon-cross-compile-sqlite-fix branch from a376555 to e226204 Compare January 17, 2023 07:49
@dpc dpc changed the title Try fixes to help cross-compile fedimint-sqlite in CI Cross-compile fedimint-sqlite in CI Jan 17, 2023
@dpc dpc marked this pull request as ready for review January 17, 2023 07:53
@dpc dpc mentioned this pull request Jan 17, 2023
Closed
dpc
dpc commented Jan 17, 2023
View reviewed changes
flake.nix
@@ -467,7 +467,7 @@
cargoArtifacts = deps;

src = filterModules dirs ./.;
cargoExtraArgs = "--package ${name} --target ${target.name}";
cargoExtraArgs = "--target ${target.name} --package ${name}";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just style change, in case you were wondering. To match the one slightly above building the deps.

@dpc dpc force-pushed the justinmoon-cross-compile-sqlite-fix branch from bf8494c to e226204 Compare January 17, 2023 08:26
@elsirion elsirion merged commit 6cc3f86 into fedimint:master Jan 17, 2023
@dpc dpc deleted the justinmoon-cross-compile-sqlite-fix branch January 17, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsirion elsirion elsirion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpc @elsirion @justinmoon