Pass the bitcoind rpc url via env variable #1289
Merged
+76
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
force-pushed
the
bitcoind-connection-env-2
branch
from
b2789db to
f090b06
Compare
dpc
force-pushed
the
bitcoind-connection-env-2
branch
from
f090b06 to
c2d6c2b
Compare
justinmoon
reviewed
Jan 12, 2023
| pub const FM_BITCOIND_RPC_ENV: &str = "FM_BITCOIND_RPC"; | ||
|
|
||
| /// Default url that will be used if [`FM_BITCOIND_RPC_ENV`] is not set | ||
| pub const FM_BITCOIND_RPC_DEFAULT_FALLBACK: &str = "http://127.0.0.1:8332"; |
There was a problem hiding this comment.
why default to mainnet?
There was a problem hiding this comment.
i guess this is the default of bitcoin-cli ...
just seem like kinda arbitrary default.
There was a problem hiding this comment.
Because that's the intended setup it's meant to be used with. Anyone not running it against mainnet, is a developer, not user, and they do an extra step, I think.
If anyone has good arguments against it, we can change. :)
justinmoon
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1288