Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock out gateway <-> federation network layer in gateway testing #1004

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

okjodom
Copy link
Contributor

@okjodom okjodom commented Nov 28, 2022

Gateway test framework changes to mock out gateway-federation network layer by using a custom client builder for gateway integration tests.

The gateway test client builder generates clients that have a mock federation api, unlike the normal clients that establish and maintain a websocket connection with some fedetation.

This is referenced in #545 , but the solution proposed by this PR is custom to the gateway test framework

@okjodom okjodom changed the title [WIP] Mock out gateway <-> federation network layer Mock out gateway <-> federation network layer in gateway testing Nov 28, 2022
@okjodom okjodom force-pushed the mock-gateway-fed-net branch from 752aad9 to 83469a4 Compare November 29, 2022 07:17
@okjodom okjodom marked this pull request as ready for review November 29, 2022 07:32
Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda incomplete, but goes into the right direction.

@elsirion elsirion merged commit b4a2881 into fedimint:master Nov 29, 2022
@okjodom okjodom deleted the mock-gateway-fed-net branch December 24, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants