Skip to content

Client's config traits should not work with raw serde_json::Value. #1297

New issue
New issue
Closed
Closed
Client's config traits should not work with raw serde_json::Value.#1297
Labels
rustImproving code quality
@dpc

Description

@dpc
dpc
opened on Jan 12, 2023

We should convert all these traits to associated types and convert internally used serde_json::Value to specific type each time.

Activity

dpc
mentioned this on Jan 12, 2023
elsirion

elsirion commented on Jan 12, 2023

@elsirion
elsirion
on Jan 12, 2023
Contributor

I assume you mean client config?

dpc
changed the title User's config traits should not work with raw `serde_json::Value`. Client's config traits should not work with raw `serde_json::Value`. on Jan 13, 2023
dpc

dpc commented on Jan 13, 2023

@dpc
dpc
on Jan 13, 2023
ContributorAuthor

I guess this might be a dup / very closely related to #1303

justinmoon
added
rustImproving code quality
on Jan 20, 2023
elsirion

elsirion commented on Jan 16, 2024

@elsirion
elsirion
on Jan 16, 2024
Contributor

I think we got this now :)

elsirion
closed this as completedon Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    rustImproving code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Client's config traits should not work with raw `serde_json::Value`. · Issue #1297 · fedimint/fedimint