Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQLite two common query problems: PrintCompletionContext and new file hash undefined for folders #3172

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

davidzwa
Copy link
Collaborator

Description

Reported through a github issue. Diagnostics came from Sentry.

@davidzwa davidzwa self-assigned this Apr 27, 2024
@davidzwa davidzwa added the bug Something isn't working label Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.71%. Comparing base (1be6e43) to head (b780e7b).

Files Patch % Lines
src/services/print-completion.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3172      +/-   ##
===========================================
- Coverage    67.74%   67.71%   -0.04%     
===========================================
  Files          214      214              
  Lines         8657     8664       +7     
  Branches      1052     1055       +3     
===========================================
+ Hits          5865     5867       +2     
- Misses        2792     2796       +4     
- Partials         0        1       +1     
Flag Coverage Δ
server-nodejs 67.71% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidzwa davidzwa merged commit d8236da into develop Apr 27, 2024
6 of 7 checks passed
@davidzwa davidzwa deleted the bug/3169-file-saving-no-hash branch April 27, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When opening printer file explorer sidenav 500 exception is thrown when saving file to db
1 participant