fix: role entity name column should be unique [ ON HOLD till 1.7.0 ] #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
davidzwa
force-pushed
the
fix/3080-make-role-name-unique-database-sqlite
branch
from
56e9841 to
e703821
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3151 +/- ##
===========================================
- Coverage 68.41% 68.40% -0.02%
===========================================
Files 208 209 +1
Lines 8524 8549 +25
Branches 1044 953 -91
===========================================
+ Hits 5832 5848 +16
- Misses 2691 2701 +10
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davidzwa
force-pushed
the
fix/3080-make-role-name-unique-database-sqlite
branch
from
e703821 to
03fe661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tackles the item in #3080 by adding a migration.
This migration will remove all roles which are duplicate and then apply an uniqueness index to the name column of the role table.
Breaking change without direct benefit. Deferring till 1.7.0.