[produce] Allow to enable/disable `access_wifi` service #13552

TaimurAyaz · 2018-10-17T18:34:25Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

iOS 12 added Access WiFi Information entitlement. Support for this was added to spaceship.portal.app_service but the triggers were not updated. Updating them in this PR.

Description

Allow produce to enable/disable access_wifi service

Added the following options to produce enable_services

--access-wifi          Enable Access WiFi

Added the following options to produce disable_services

--access-wifi         Disable Access WiFi

googlebot · 2018-10-17T18:34:27Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

TaimurAyaz · 2018-10-17T19:00:42Z

@googlebot I signed it!

googlebot · 2018-10-17T19:00:45Z

CLAs look good, thanks!

betko · 2018-10-30T09:40:02Z

Do you have plan to merge this feature?

TaimurAyaz · 2018-10-30T16:40:04Z

@betko I am waiting on a review.

TaimurAyaz · 2018-10-31T18:40:36Z

Bump

joshdholtz

Thanks for adding these in! Can you also change AccessWiFi to AccessWifi on https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/portal/app_service.rb#L43?

Right now the current changes fail because they are expecting Spaceship.app_service.access_wifibut it is actually Spaceship.app_service.access_wi_fi because of the capital F on the line of code I linked above. If you change AccessWiFi to AccessWifi then your code changes will work 😊

TaimurAyaz · 2018-11-02T16:33:00Z

Ah, right. Will do 👍

joshdholtz · 2018-11-05T23:49:31Z

@TaimurAyaz Heyyyy! Are you cool if I add a commit to make this change? 😊

TaimurAyaz · 2018-11-06T05:21:04Z

@joshdholtz go for it :)

alexzchut · 2018-11-27T11:47:11Z

@TaimurAyaz @joshdholtz Please update when this feature will be merged. Thanks!

alexzchut · 2018-12-10T16:03:46Z

@TaimurAyaz @joshdholtz Any news on merging this?
It is new feature being required for example for Chromecast support and currently only way is to enable it manually. If this PR is ready to be merged, please do to finally automate this ability...
Thanks a lot!

antoinerabanes · 2018-12-21T23:02:22Z

bump +1 I am running into this issue too

googlebot · 2018-12-22T11:09:02Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Changed AccessWiFi to AccessWifi

janpio · 2018-12-22T11:12:25Z

I did make the change. Please review code again.

joshdholtz

We can ship this! 🙌

fastlane-bot · 2019-01-17T19:33:55Z

Congratulations! 🎉 This was released as part of fastlane 2.114.0 🚀

googlebot added the cla: no label Oct 17, 2018

googlebot added cla: yes and removed cla: no labels Oct 17, 2018

Allow produce to enable/disable access_wifi service

87a546c

TaimurAyaz force-pushed the add_new_services_to_produce branch from 82d38e3 to 87a546c Compare October 17, 2018 19:13

fastlane-bot added the status: needs-attention label Nov 1, 2018

joshdholtz previously requested changes Nov 2, 2018

View reviewed changes

janpio added tool: produce and removed status: needs-attention labels Nov 13, 2018

fastlane-bot added the status: needs-attention label Nov 14, 2018

janpio changed the title ~~Allow produce to enable/disable access_wifi service~~ [produce] Allow to enable/disable access_wifi service Nov 22, 2018

AccessWiFi => AccessWifi

5a49d52

googlebot added cla: no and removed cla: yes labels Dec 22, 2018

janpio mentioned this pull request Dec 22, 2018

Add new services to produce #13982

Closed

joshdholtz approved these changes Jan 17, 2019

View reviewed changes

joshdholtz merged commit e012e3e into fastlane:master Jan 17, 2019

joshdholtz mentioned this pull request Jan 17, 2019

Version bump to 2.114.0 #14073

Merged

fastlane-bot added status: released and removed status: needs-attention labels Jan 17, 2019

FitrahRama mentioned this pull request Jan 31, 2019

Missing changelog for supply Android bundle to internal track #13616

Closed

4 tasks

fastlane locked and limited conversation to collaborators Mar 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[produce] Allow to enable/disable `access_wifi` service #13552

[produce] Allow to enable/disable `access_wifi` service #13552

TaimurAyaz commented Oct 17, 2018 •

edited

Loading

googlebot commented Oct 17, 2018

TaimurAyaz commented Oct 17, 2018

googlebot commented Oct 17, 2018

betko commented Oct 30, 2018

TaimurAyaz commented Oct 30, 2018

TaimurAyaz commented Oct 31, 2018

joshdholtz left a comment

TaimurAyaz commented Nov 2, 2018

joshdholtz commented Nov 5, 2018

TaimurAyaz commented Nov 6, 2018

alexzchut commented Nov 27, 2018 •

edited

Loading

alexzchut commented Dec 10, 2018

antoinerabanes commented Dec 21, 2018

googlebot commented Dec 22, 2018

janpio commented Dec 22, 2018

joshdholtz left a comment

fastlane-bot commented Jan 17, 2019

[produce] Allow to enable/disable access_wifi service #13552

[produce] Allow to enable/disable access_wifi service #13552

Conversation

TaimurAyaz commented Oct 17, 2018 • edited Loading

Checklist

Motivation and Context

Description

googlebot commented Oct 17, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

TaimurAyaz commented Oct 17, 2018

googlebot commented Oct 17, 2018

betko commented Oct 30, 2018

TaimurAyaz commented Oct 30, 2018

TaimurAyaz commented Oct 31, 2018

joshdholtz left a comment

Choose a reason for hiding this comment

TaimurAyaz commented Nov 2, 2018

joshdholtz commented Nov 5, 2018

TaimurAyaz commented Nov 6, 2018

alexzchut commented Nov 27, 2018 • edited Loading

alexzchut commented Dec 10, 2018

antoinerabanes commented Dec 21, 2018

googlebot commented Dec 22, 2018

janpio commented Dec 22, 2018

joshdholtz left a comment

Choose a reason for hiding this comment

fastlane-bot commented Jan 17, 2019

[produce] Allow to enable/disable `access_wifi` service #13552

[produce] Allow to enable/disable `access_wifi` service #13552

TaimurAyaz commented Oct 17, 2018 •

edited

Loading

alexzchut commented Nov 27, 2018 •

edited

Loading