docs: add test examples with undici and fetch #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
jsumners
reviewed
Sep 23, 2022
mcollina
requested changes
Sep 23, 2022
There was a problem hiding this comment.
Note that you should keep keepAliveTimeout and keepAliveTimeoutMax set low (like 10): https://undici.nodejs.org/#/docs/api/Client?id=parameter-clientoptions. Otherwise in Node.js v16 and v14 the test will keep running for long.
(verify this!)
ghost
requested review from
jsumners and
mcollina
and removed request for
jsumners and
mcollina
mcollina
reviewed
Sep 26, 2022
ghost
requested review from
jsumners and
mcollina
and removed request for
jsumners and
mcollina
L2jLiga
reviewed
Sep 30, 2022
Uzlopak
approved these changes
Oct 4, 2022
simoneb
reviewed
Oct 4, 2022
jsumners
requested changes
Oct 4, 2022
|
@jsumners I added a description of the second example: |
jsumners
reviewed
Oct 4, 2022
ghost
requested review from
simoneb and
jsumners
and removed request for
simoneb
jsumners
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4296.
Checklist
npm run testandnpm run benchmarkand the Code of conduct