Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update includes for docs/de/docs/python-types.md #12660

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

alissadb
Copy link
Contributor

📝 Update includes for docs/de/docs/python-types.md

@github-actions github-actions bot added the lang-all Translations label Oct 28, 2024
Copy link
Contributor

@alejsdev alejsdev closed this Oct 28, 2024
@alejsdev
Copy link
Member

Hi @alissadb, thanks for your interest in contributing to FastAPI. However, this is a special case, you have to stick to the previous version in some of the cases, see #12551 for reference.

If you want you can adjust it, I'll reopen it in the meantime. Thanks! 🙌

@alejsdev alejsdev reopened this Oct 28, 2024
@alejsdev alejsdev added changes-requested docs Documentation about how to use FastAPI and removed lang-all Translations labels Oct 28, 2024
@github-actions github-actions bot added the lang-all Translations label Oct 28, 2024
@alejsdev alejsdev removed the lang-all Translations label Oct 28, 2024
@github-actions github-actions bot added the lang-all Translations label Oct 28, 2024
@alejsdev alejsdev removed the lang-all Translations label Oct 28, 2024
@alissadb
Copy link
Contributor Author

@alejsdev Thank you! I have updated the PR, I noticed than in the previous PR this was not changed. Should I also keep it unchanged as well?

Copy link
Contributor

@alejsdev
Copy link
Member

Hi @alissadb, it would depend on the context.
In the original we kept the old version in some cases as it has some additional explanations (https://fastapi.tiangolo.com/python-types/)

The ideas is to keep this consistency in other languages.

@alejsdev alejsdev merged commit 890a61f into fastapi:master Nov 9, 2024
53 of 54 checks passed
@alejsdev
Copy link
Member

alejsdev commented Nov 9, 2024

Thanks for your help! @alissadb 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants