Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the check which removes None values #171

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

shreve
Copy link
Contributor

@shreve shreve commented Apr 3, 2024

None (null) is a valid value for several GitHub API endpoints. This commit removes a line which strips these valid values from all requests.

(Credit to @reaganbarker for finding this #81 (comment))

Fixes #81

`None` (`null`) is a valid value for several GitHub API endpoints. This
commit removes a line which strips these valid values from all requests.

Credit to @reaganbarker for finding this.
AnswerDotAI#81 (comment)
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@shreve shreve marked this pull request as ready for review April 3, 2024 16:54
@jph00 jph00 merged commit df2a68f into AnswerDotAI:master Apr 4, 2024
@jph00
Copy link
Contributor

jph00 commented Apr 4, 2024

Many thanks!

@shreve shreve deleted the null-parameters branch April 4, 2024 15:01
@jph00 jph00 added the bug Something isn't working label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommended way of sending null as a parameter
2 participants