Add support for media types #102
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
For some endpoints GitHub lets you request different response format using the `Accept` header [[1]]. However, by default if the response is not in JSON format `GhApi.__call__` will raise an error. This commit makes it possible by adding a bit of logic to look at the `Accept` header in the request and tell `fastcore.core.urlsend` not to return JSON if it doesn't look like the user is requesting a JSON media type. [1]: https://docs.github.com/en/rest/overview/media-types
lfdebrux
force-pushed
the
lfdebrux-add-media-types-support
branch
from
25a9182 to
263fc04
Compare
|
I was looking into mimetype support as well. I wonder if adding an extra argument to (Eg. there is a slight chance that a non-json mimetype contains the "json" string -- or that a json-based format doesn't). So eg. change the signature to: def __call__(
self,
path:str,
verb:str=None,
headers:dict=None,
route:dict=None,
query:dict=None,
data=None,
return_json:bool=True,
):
# ... |
|
@rshk I considered this initially, but it seemed a bit unnecessary because a) I think the developer's intent is already made clear by changing the accept header b) with a |
|
Many thanks! FYI you forgot to run |
For some endpoints GitHub lets you request different response format using the
Acceptheader [1]. However, by default if the response is not in JSON formatGhApi.__call__will raise an error.This commit makes it possible by adding a bit of logic to look at the
Acceptheader in the request and tellfastcore.core.urlsendnot to return JSON if it doesn't look like the user is requesting a JSON media type.