-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add farmOS-timeline library #862
Conversation
84c7f8e
to
a79c7f7
Compare
composer.libraries.json
Outdated
"type": "package", | ||
"package": { | ||
"name": "farmos/farmos-timeline", | ||
"version": "0.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to make a new release of the timeline library - we got a new release of the gantt library that should make a few things easier!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay this should be ready for review again. I updated farmos-timeline to v0.0.2 and fixed a bug with the parent/child row processing that was implemented in I think something got goofed while I was originally working on this and making commits/rebasing.. not entirely sure but I noticed there is still a fixup commit in this PR. So I've squashed that as I originally intended and then added 3 new follow-up commits. Available in this branch: https://github.com/paul121/farmOS/tree/3.x-timeline-fixed |
@mstenta I should say that I tried testing this with the crop plan and it was working well. The current branch of the grazing plan doesn't seem to work with this timeline branch from farmOS core, it is dependent on some other features maybe? I get an error when trying to install the grazing plan that I'd rather not worry about debugging right now... :-) |
6a3b4b2
to
e12b576
Compare
Rebased onto latest 3.x and merged @paul121's |
These are copied directly from the contrib farm_crop_plan module, originally authored by @paul121.
These are copied directly from the contrib farm_crop_plan module. Only crop plan specific CSS styles have been removed.
This causes null or undefined to be rendered as text on the page
This uses the updated draggable and resizable attributes from the upstream gantt library
e12b576
to
a240c0f
Compare
This adds the farmOS-timeline library to farmOS, via a new
farm_timeline
module with supporting code and render element.This depends on #850, and therefore includes its commits.