Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML linter configuration #714

Merged
merged 1 commit into from
Jul 10, 2019
Merged

YAML linter configuration #714

merged 1 commit into from
Jul 10, 2019

Conversation

leodido
Copy link
Member

@leodido leodido commented Jul 9, 2019

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

This PR simply adds a basic yamllint configuration in order to also start the process of establish (and document) the coding style of the repo's YAML files (rules, falco config etc.).
The YAML lint config created extends the default one disabling some linting rules in order to minimize the mismatch from the current YAML style the repo contains.

Please notice this PR does NOT reformat any YAML file.

Which issue(s) this PR fixes:

Refs #619

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

fntlnz
fntlnz previously approved these changes Jul 9, 2019
@poiana poiana added the lgtm label Jul 9, 2019
@poiana
Copy link
Contributor

poiana commented Jul 9, 2019

LGTM label has been added.

Git tree hash: caeba50f04d453bafdbda9cd7ae021b0d77ed568

@poiana poiana added the approved label Jul 9, 2019
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jul 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Jul 10, 2019
@poiana
Copy link
Contributor

poiana commented Jul 10, 2019

LGTM label has been added.

Git tree hash: 705717404794ca57183d5d05ac521d746e61c8ee

@leodido leodido merged commit 4c68da0 into dev Jul 10, 2019
@poiana poiana deleted the new/yaml-lint-config branch July 10, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants